-
-
Notifications
You must be signed in to change notification settings - Fork 245
Docs: Display emoji/notice for rules with suggestions #860
Conversation
✔️ Deploy Preview for eslint ready! 🔨 Explore the source changes: b6ceb5f 🔍 Inspect the deploy log: https://app.netlify.com/sites/eslint/deploys/6102ee861ea44e00079f58d5 😎 Browse the preview: https://deploy-preview-860--eslint.netlify.app/docs/rules |
9b04a51
to
aae6957
Compare
640dd74
to
afe7bf3
Compare
afe7bf3
to
9d12b13
Compare
Force-pushing seems to be messing up the deploy preview. There’s no need to force-push, you can keep adding new commits. We only check the first commit message so the pressure is off. :) can you try adding a new commit to see if it triggers the deploy preview to regenerate? |
Will rules.yml get automatically regenerated at some point? I manually updated the relevant parts. |
Yes, it gets updated on each ESLint release. (not including prereleases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Preview LGTM! Note about merging: If we want to merge this after we merge eslint/eslint#14830 and do the release, then we should undo the changes in |
Sounds good. Just reverted |
Fixes #859.
Other part required for this change: eslint/eslint#14830